Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2749: Fixes Home Card UI #5185

Merged
merged 12 commits into from
Feb 19, 2024
Merged

Fix #2749: Fixes Home Card UI #5185

merged 12 commits into from
Feb 19, 2024

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Oct 11, 2023 •
edited
Loading

Explanation

Fixes #2749

Modifies margin and padding values

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Tablet Screenshots

1920 x 1200

Before After
1920 x 1200 port before 1920 x 1200 port after
1920 x 1200 before 1920 x 1200 after

2560 x 1800

Before After
2560 x 1800 port before 2560 x 1800 port after
2560 x 1800 before 2560 x 1800 after

1024 x 600

Before After
1024 x 600 before 1024 x 600 after

Phone Screenshots

dpi Screenshots
ldpi image
mdpi image
hdpi image
xhdpi imageimage
xxhdpi imageimage

@theMr17 theMr17 requested a review from a team as a code owner October 11, 2023 07:04
@theMr17 theMr17 requested a review from adhiamboperes October 11, 2023 07:04
@github-actions
Copy link

Hi! @theMr17 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

@oppiabot
Copy link

oppiabot bot commented Oct 18, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 18, 2023
@adhiamboperes adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 18, 2023
@adhiamboperes
Copy link
Collaborator

@BenHenning, I'm not really sure what solution is required for this issue... a recalculation or margin adjustments?

adhiamboperes
adhiamboperes reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theMr17, the issue linked screenshots from different tablet devices. It would be nice to create comparable ones after your final solutions, to show that the screen displays okay in devices where it was previously distorted.

@BenHenning BenHenning mentioned this pull request Oct 24, 2023
Closed
@BenHenning
Copy link
Member

@adhiamboperes I left a comment in #2749 to try and provide more clarity. Please let me know if additional info is needed.

@adhiamboperes
Copy link
Collaborator

@adhiamboperes I left a comment in #2749 to try and provide more clarity. Please let me know if additional info is needed.

Thanks @BenHenning, @theMr17, let's pick up this discussion on the issue thread.

@oppiabot OppiaBot
Copy link

oppiabot bot commented Oct 31, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 31, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 5, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 13, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 13, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 16, 2023
@theMr17
Copy link
Collaborator Author

theMr17 commented Nov 17, 2023

As per Ben's comment, I revisited the tile sizes across device configurations. I have made the necessary changes with the tile sizes by adjusting the margin and padding values. I have also added screenshots for different tablet devices above, @adhiamboperes PTAL.

@oppiabot oppiabot bot assigned adhiamboperes and unassigned theMr17 Nov 17, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 17, 2023

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 5, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 12, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 12, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 12, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 19, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 19, 2024
@adhiamboperes
Copy link
Collaborator

I think this needs veryfying with prod assets that everything looks good. ETA tomorrow(Tue/23).

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 22, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 29, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 29, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 31, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 7, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 7, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 7, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 14, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 14, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 14, 2024
adhiamboperes
adhiamboperes approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! I think per #2749 (comment), the latest screenshots look sufficiently good to solve this issue.

@adhiamboperes adhiamboperes enabled auto-merge (squash) February 19, 2024 10:18
@oppiabot oppiabot bot added the PR: LGTM label Feb 19, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 19, 2024

Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit 58845ad into oppia:develop Feb 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@theMr17 theMr17

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home Topic Card UI Regression
4 participants
@theMr17 @adhiamboperes @BenHenning @Vishwajith-Shettigar